snyk / nodejs-lockfile-parser

Generate a Snyk dependency tree from package-lock.json or yarn.lock file
Other
59 stars 28 forks source link

Allow yarn 2 resolutions #100

Closed mhassan1 closed 3 years ago

mhassan1 commented 3 years ago

What this does

Yarn 2 resolutions breaks snyk test. See https://github.com/snyk/nodejs-lockfile-parser/issues/99 for details. This PR unblocks consumers that have yarn 2 resolutions when --strict-out-of-sync=false is passed to the Snyk CLI.

Notes for the reviewer

See additional test case for yarn 1 and yarn 2` resolutions.

orsagie commented 3 years ago

Hi @mhassan1 Thanks for your contribution 🙏 . I have added a task for us to go over the PR this sprint.

JamesPatrickGill commented 3 years ago

Hey @mhassan1 We have been looking into getting this contribution merged and have merged these commits into another PR (https://github.com/snyk/nodejs-lockfile-parser/pull/102) to squash the commits and get the checks to pass. Interestingly once the checks passed on the PR, they passed over here too.

We are going to merge your commits into master from the other PR and close this as that is our current process.

Thanks for your contribution 😀