snyk / nodejs-lockfile-parser

Generate a Snyk dependency tree from package-lock.json or yarn.lock file
Other
59 stars 28 forks source link

fix: make sure to be able to parse big lockfiles for yarn 2 #108

Closed jan-stehlik closed 3 years ago

jan-stehlik commented 3 years ago

What this does

Support very large yarn.lock files using yarn 2 package manager.

Before:

Screenshot 2021-05-07 at 12 55 10

After:

Screenshot 2021-05-07 at 12 55 20

Furthermore this PR covers

Notes for the reviewer

Sorry about very big diff but most of the changes are just fixture changes, especially new huge lock file .

Most relevant files to review are:

To manually test please follow these steps:

npm link # in this repo
npm i && npm run build
cd snyk repo
npm link snyk-nodejs-lockfile-parser
npm run build
node dist/cli/index.js test path/to/nodejs-lockfile-parser/test/fixtures/yarn/yarn2/big

Expected result: vulnerabilies are successfully scanned

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

snyksec commented 3 years ago

:tada: This PR is included in version 1.34.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: