Closed abdulhannanali closed 1 month ago
@lirantal Could you take a look at this when you get a chance, so we can move https://github.com/lirantal/lockfile-lint/issues/101 forward?
Hey @abdulhannanali , thanks for raising this PR! We currently have some WIP branch and prioritised to do some work on this area in the next sprint (or the one after) we'll see what's missing and might use this PR
We'll let you know when we'll get to this
@admons Thanks for considering. I look forward for this integration. Just curious, is it about the dependency graph? I would love to contribute in that area, if given some directions about approach, if you're accepting contributions there.
@milahu Thank you very much for approving. I am up for resolving the merge conflicts, if you would like.
Hello! Would be keen to know the status of this PR? It seemed like it was addressing missing features from the lockfile parsing logic. @lirantal @admons
@JamesPatrickGill , sorry to tag, would be keen on knowing what could be done for this PR to reset/progress again?
Your PR has not had any activity for 60 days. In 7 days I'll close it. Make some activity to remove this.
Your PR has now been stale for 7 days. I'm closing it.
What this does
This PR mainly adds following four properties to the lockfile dependency tree that were previously ignored
resolved
integrity
checksum
resolution
It also updates the expected dependency tree fixtures accordingly and moves
yarn.test.ts
to thejest
. The file was moved to jest since it was timing out with tap and the test comparison was taking forever to run. I pledge to move the whole test code of this repo to Jest and also add snapshotting to make it simpler for everyone to add properties in future.Explain why this PR exists
This PR exists since we want this functionality for https://github.com/lirantal/lockfile-lint/issues/101 and @orsagie showed willingness for these properties to be added in the repo #98
Notes for the reviewer
Instructions on how to run this locally, background context, what to review, questions…
More information
Screenshots
Visuals that may help the reviewer