fix: resolve nested deps to matching version - Githubissues

snyk / nodejs-lockfile-parser

Generate a Snyk dependency tree from package-lock.json or yarn.lock file

Other

56 stars 28 forks source link

fix: resolve nested deps to matching version #202

Closed klesniewski closed 5 months ago

klesniewski commented 10 months ago

[X] Tests written and linted
[ ] Documentation written / README.md updated https://snyk.io/docs/snyk-for-node/
[X] Follows CONTRIBUTING agreement
[X] Commit history is tidy https://git-scm.com/book/en/v2/Git-Branching-Rebasing
[X] Reviewed by Snyk team

What this does

Fixes resolving dependencies in NPM lockfile v2. In some cases, when multiple versions of a dependency are present, in some places a wrong version was picked up.
Adds testing against npm ls output, so we know our results are consistent.
Fixes test fixtures to match npm ls output.

CLAassistant commented 10 months ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}