Update init.gradle - Githubissues

snyk / snyk-gradle-plugin

Basic Snyk CLI plugin for Gradle support

Other

25 stars 19 forks source link

Update init.gradle #109

Closed RaySinnema closed 4 years ago

RaySinnema commented 4 years ago

Processed dependencies can be found later as transitive dependencies of other dependencies.

[ ] Ready for review
[ ] Follows CONTRIBUTING rules
[ ] Reviewed by Snyk internal team

What does this PR do?

Fix issue with OOM when there are many dependencies with the same transitive dependencies, e.g. using Spring Boot.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

https://support.snyk.io/hc/en-us/requests/3355

Screenshots

Additional questions

claassistantio commented 4 years ago

All committers have signed the CLA.

lili2311 commented 4 years ago

👋 @RemonSinnema thanks for this! Would you be able to also add a test that shows the issue and that it is now fixed? Or at least share an example project that is buildable to verify before & after

RaySinnema commented 4 years ago

See the support request https://support.snyk.io/hc/en-us/requests/3355. Without the fix, I get an OOM. With the fix I don't. Unfortunately, I can't share the project I'm testing this on...

lili2311 commented 4 years ago

Great! no worries, any chance of a slimmed down test fixture instead?

lili2311 commented 4 years ago

@RemonSinnema closing this PR as this breaks existing functionality, let's keep chatting on the support case to fins a solution.