fix: scanning failure caused by missing proj-name - Githubissues

snyk / snyk-gradle-plugin

Basic Snyk CLI plugin for Gradle support

Other

25 stars 19 forks source link

fix: scanning failure caused by missing proj-name #181

Closed anthogez closed 3 years ago

anthogez commented 3 years ago

fix:

While processing snykGraphs from extractedJSON to depGraph, projectName is generated using the basename of the rootDir,
we were not handling it if by any chance it was null or undefined. Now that we handling it properly, we are preventing possible scanning errors.

refactor:

Clarifying the purpose of few functions
Moving the loop where we process all the existing projects in the extractedJSON from snykGraph to depGraph away from getAllDeps to its own function processProjectsInExtractedJSON, makes the projects process testable, enabling us of have more confidence on expected results
Added a test for processProjectsInExtractedJSON

snyksec commented 3 years ago

:tada: This PR is included in version 3.14.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: