Use complete project path when filtering subprojects

snyk / snyk-gradle-plugin

Basic Snyk CLI plugin for Gradle support

Other

25 stars 19 forks source link

Use complete project path when filtering subprojects #268

Closed damianw closed 9 months ago

damianw commented 11 months ago

[ ] Tests written and linted
[X] Documentation written
[X] Commit history is tidy

What this does

This resolves #195, allowing the tool to properly recognize --sub-project arguments that refer to nested subprojects, e.g. foo/bar for the Gradle project path :foo:bar. Currently, this does not work.

Notes for the reviewer

I'm not sure how to write the test for this, since I haven't dug into the repo too much. Please let me know if you have a recommendation for anything else that needs to be done.

How should this be manually tested?

Ran with --sub-project for a nested Gradle subproject, e.g. foo/bar, and found it to be recognized.

CLAassistant commented 11 months ago

All committers have signed the CLA.

anthogez commented 11 months ago

Thanks @damianw for your collaboration, we will review your changes and loop back to you.

37IulianPopovici commented 9 months ago

Hey @damianw! We would love to keep you as a contributor on this change, so, can you please make a new branch and open a new PR with the exact change from our main project? Your change is great, but I want to add some small updates (tests mainly), and I cannot add them here.

damianw commented 9 months ago

Thanks @37IulianPopovici! I don't have permission to create a branch on this repo, if that's what you're asking. I'm happy to do that if given permission, but I also don't mind if you commandeer this change and take ownership of it.

37IulianPopovici commented 9 months ago

Hey @damianw, thanks a lot for your patience! Waiting for the cli PR to be approved and released

damianw commented 9 months ago

Thanks, appreciate you looking into it!