search

snyk / snyk-nuget-plugin

Basic Snyk CLI plugin for .NET support.
Other
5 stars 14 forks source link

feat: [OSM-347] Return multiple results part 3: Doubtless `TargetFramework`s. #175

Closed dotkas closed 11 months ago

dotkas commented 11 months ago

Part 1: https://github.com/snyk/snyk-nuget-plugin/pull/172 Part 2: https://github.com/snyk/snyk-nuget-plugin/pull/173

This PR paves the way for actually accessing the right dependency details based on the supplied targetFramework.

It removes the reinvented-wheel logic of using a project parser to guess what target framework to use, but instead utilizes the actual .NET code to parse the target framework.

Once this is merged, it should be just the last thing remaining, which is to return single or multiple results based on how many <TargetFramework> directives we detect.

snyksec commented 11 months ago

:tada: This PR is included in version 1.37.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: