search

snyk / snyk-nuget-plugin

Basic Snyk CLI plugin for .NET support.
Other
5 stars 14 forks source link

fix: [OSM-1718] Fix `isPublishable` error on older dotnet versions #208

Closed dotkas closed 4 months ago

dotkas commented 4 months ago

This user-friendly update: https://github.com/snyk/snyk-nuget-plugin/pull/207 was a tad too friendly. Any .NET version other than 8 caused it to fail.

Though I still believe in the power of useful error messages, and the SCM solution will still benefit from this. The alternative is a weird dotnet crash with a missing .deps file.

So this is the compromise.

The CCI runners are already running .NET 8 and thus tests are still passing. The negative case is a bit more cumbersome, as most fixtures targeting .NET 8 will fail with a .NET 7/6 executor.

snyksec commented 4 months ago

:tada: This PR is included in version 2.4.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: