search

snyk / user-docs

Gitbook documentation repo.
https://docs.snyk.io/
22 stars 179 forks source link

Potentially out of date docs regarding pnpm #324

Closed JamesSingleton closed 10 hours ago

JamesSingleton commented 3 weeks ago

I was looking to see if Snyk supported the latest version of pnpm as v8 is no longer actively maintained. I came across

### [SNYK-OS-NODEJS-0017](#snyk-os-nodejs-0017)

#### Unsupported pnpm lockfile version

The lockfile version is not supported. Supported lockfile versions for pnpm include v5 and v6.

and

### Lerna/PNPM

Not officially supported, but if configured with Yarn workspaces, you may get Snyk IDE/CLI results.

This would lead me to believe that Snyk does not support it. However, I found Node.js Lockfile Parser which states

Dep graph generation supported for:

- `package-lock.json` (at Versions 2 and 3)
- `yarn.lock`
- `pnpm-lock.yaml` (lockfileVersion 5.x, 6.x and 9.x)

That to me would suggest that pnpm is supported, but that the docs suggest otherwise.

awileysnyk commented 3 weeks ago

I am sending this question to the team that can respond and will come back with the answer and a resolution. Thank you for the question. Please let me know where you found the three sections cited at the beginning of your message. I co uld not be sure from searching. Thank you.

JamesSingleton commented 3 weeks ago

I am sending this question to the team that can respond and will come back with the answer and a resolution. Thank you for the question. Please let me know where you found the three sections cited at the beginning of your message. I co uld not be sure from searching. Thank you.

I searched from “pnpm” in the Snyk org is how I found the code. I also searched on https://docs.snyk.io/ and found https://docs.snyk.io/supported-languages-package-managers-and-frameworks/javascript/best-practices-for-javascript-and-node.js#lerna-pnpm and https://docs.snyk.io/scan-using-snyk/error-catalog#snyk-os-nodejs-0017

awileysnyk commented 3 weeks ago

Thank you. This will help the experts determine how to answer your question. Some experts are away at this time, and I will let you know what they have told me as soon as possible.

awileysnyk commented 1 week ago

Thank you again for raising this issue. Some experts remain away. This issue has also been raised on an internal channel, and we will find a resolution.

awileysnyk commented 10 hours ago

Documentation is being added for pnpm. This will be published in the near future when the feature is released. Thank you.

awileysnyk commented 10 hours ago

Closing this issue. Thank you again for the question.