search

snyk / vulncost

Find security vulnerabilities in open source npm packages while you code
https://marketplace.visualstudio.com/items?itemName=snyk-security.vscode-vuln-cost
MIT License
201 stars 38 forks source link

chore: adds commit lint #27

Closed thisislawatts closed 4 years ago

thisislawatts commented 4 years ago

Now that releases are being generated automatically with semantic-release we should check commit formatting to ensure relevant details will be included as part of our changelog and GitHub releases.

thisislawatts commented 4 years ago

What do you mean here @bmvermeer ?

bmvermeer commented 4 years ago

You removed the "check" script.

The tool we use to publish to the marketplace see DEVELOPMENT.md is calling the npm run check

thisislawatts commented 4 years ago

Aha gotcha! I am still not sure if this linting check is going to work with the current workflow as we have branches with Merge… commits which would fail the linting validation.