snyk / vulncost

Find security vulnerabilities in open source npm packages while you code
https://marketplace.visualstudio.com/items?itemName=snyk-security.vscode-vuln-cost
MIT License
200 stars 34 forks source link

click to fix - not working on tap pkg #32

Open remy opened 4 years ago

remy commented 4 years ago
Screenshot 2020-04-30 at 17 09 32

Two points here:

  1. Clicking didn't do anything, I had to go away from the decoration and to the 'tap' line, hover, open menu, then select 'fix'.
  2. From there, it says there's no rememdiation available - so it can't actually be fixed.
rajivshah3 commented 3 years ago

One other issue is that "fix vuln" shows even though a vulnerability is not fixable: image

I'm happy to make a PR to fix this, but I'm not sure what it should say instead

MaggieFero commented 3 years ago

Maybe "Remediation options"? I checked a few in my own repos, and it seems to provide some additional details (but less than the page at "Learn about this vulnerability") with either

The extension already expects people to know the term "remediation" once they click on the button, so it's not introducing any new language complexity to use it here. It would also still be shorter than the following text string, so space shouldn't be an issue.