search

snystrom / memes

An R interface to the MEME Suite
https://snystrom.github.io/memes/
Other
43 stars 5 forks source link

runfimo() throws an error when there are no results found and an outdir provided #86

Closed tensulin closed 2 years ago

tensulin commented 2 years ago

If the text = F and outdir param with runFimo is set and no Fimo found no results then the function will throw an error

snystrom commented 2 years ago

Ah, good catch. I will change the behavior to instead print an informative message and return NULL instead (which is the behavior if text == TRUE). I'll ping here when it's fixed (hopefully in the next day or two).

Thanks for the issue report!

tensulin commented 2 years ago

You are welcome! Thanks for the fix and for the package! It is really helpfull

snystrom commented 2 years ago

Ok, I think I got the bug fixed. I pushed the changes to the Bioconductor release branch as well, but I would suggest installing the development version from github instead using:

remotes::install_github("snystrom/memes") to ensure you get the bugfix release (it usually takes a bit for the build to propagate to Bioconductor servers). The current development version is identical to the bioconductor release, so you shouldn't have any issues using this version for now.

Thanks again for the bug report. If you still have the issue after you update, feel free to reopen the issue.