search

so-rose / convmlv

A feature-rich RAW developer for Magic Lantern formats.
https://git.sofusrose.com/so-rose/convmlv
GNU General Public License v3.0
15 stars 0 forks source link

.DNG extension throwing error #25

Open thennicke opened 7 years ago

thennicke commented 7 years ago

Line 1997 of convmlv.sh: mv "${3}/${name%.*}.DNG" "${3}/${name%.*}.dng" #Rename *.DNG to *.dng. has no condition on it, so throws an error if there are no .DNG files. I have tested this program with normal and dual_iso MLV files, and only the dual_iso ones seem to trigger this error. (Would fix it myself but I'm not yet very familiar with Bash)

so-rose commented 7 years ago

Thanks for the bug report!

That line is triggered when developing dual ISO DNGs (the inc_iso function). It runs, for each orig.dng in the sequence:

The explanation seems to be that, for whatever reason, cr2hdr doesn't generate orig.DNG. It could be that mlv_dump failed, or that cr2hdr failed - usually because of the options passed in. I doubt mlv_dump is the problem, though, but cr2hdr is probably the option.

As such, adding a conditional on it probably wouldn't help if cr2hdr is failing. It's not pretty code :) thats what the modularize branch is for!

But. Could you perhaps post the convmlv command and/or config file that you used?

thennicke commented 7 years ago

Oh, I see. Thanks for the explanation. The command I'm using is ./convmlv.sh --config ~/Projects/convmlv/configs/global.conf -k -r 1-10 -u -m ~/Videos/MLRAW/Samples/dual_iso_25fps1080.MLV And my global.conf is global.txt (changed file extension so I could upload it here) I'm using a custom LUT but otherwise that should work.