so010 / knockplop

Basic meeting webservice (client + server) based on WebRTC technology
MIT License
19 stars 9 forks source link

Chrome screensharing plugin #24

Open so010 opened 6 years ago

so010 commented 6 years ago

For now we just use this extension here: https://chrome.google.com/webstore/detail/janus-webrtc-screensharin/hapfgfdkleiggjjpfpenajgdnfckjpaj?utm_source=chrome-app-launcher-info-dialog

This is a little bit misleading to the user because knockplop is not a janus related service. Alternatives:

1. Fork janus extension or any other open source extension, make it "product neutral" and notice the user about the potential security risk because it is allowing every webside to acces your screen! Make in install documentation one section about how to setup your own secure chrome-extension.

  1. make a knockplop screensharing extension and whitlist all participating registered knockplop services.

maybe we could implement both alternatives...

misi commented 6 years ago

I am not happy with the actual behavior and want to implement 2.

During last dev-meeting I mentioned that registered site needed, but I couldn't recall the reason. Now I found it, the reason is inline install.

Verified site requirement

For security reasons, inline installations can only be initiated by a page on a site that is verified (via Webmaster Tools) as being associated with that item in the Chrome Web Store.

See inline Install in detailed: https://developer.chrome.com/webstore/inline_installation?hl=hu

misi commented 6 years ago

As decided I already separated the plugin: https://github.com/misi/knockplop-chrome-plugin TODO: Add a description how to setup.

2. I have made already a plugin that we could use. https://chrome.google.com/webstore/detail/knockplop-screensharing/glaipmkfbnnfjblbajlffkekbnebkpgg TODO: update icons any visual elements:

misi commented 6 years ago

At least it is needed to make it configurable which plugin the service operator want to use: See this commit chrome service with inline/auto install. https://github.com/misi/knockplop/commit/17b254326227813c919331c459ff77dc86f7ceaa

so010 commented 6 years ago

Merged PR from misi for now, but this solves not the issue. We need more discussion here I think. As far as I understand the verified site requirement from chrome-plugin is for inline installation, so if the actual site is not verified it could just link to the extention and use it anyway with a little bit more user interaction? In that case I'm fine with this.

misi commented 6 years ago

I think you see now the situation correctly, and sorry for the confusion I made. If so then our points I think splited in two ways, and so we need to make it configurable.. Because I still want to stick and take the advantage of inline extension install, to give better user experience in my services.

misi commented 6 years ago

The three way and howto: