so1ve / vue-skinview3d

Three.js powered Minecraft skin viewer. (Vue binding of skinview3d)
https://vue-skinview3d.mk1.io
MIT License
10 stars 2 forks source link

Abillity to hard-reset rotation #54

Closed InstantlyMoist closed 9 months ago

InstantlyMoist commented 9 months ago

Hi,

Is there a way to hard-reset the rotation on the skin. So if it stops auto-rotating I can snap it back into it's 'default' spot

so1ve commented 9 months ago

I'll look into this

so1ve commented 9 months ago

Hi @InstantlyMoist, I've looked into this feature request and I found I can do nothing in this project. You'd better file this issue in https://github.com/bs-community/skinview3d and I'll follow it up

InstantlyMoist commented 9 months ago

Would there be a way to call the 'resetCameraPos' method? Either way I'll make an issue for them. Thanks

InstantlyMoist commented 9 months ago

Thanks for your work so far, i've been trying to get it working within a component. But I'm failing miserably. I created a test.vue page and pasted the playground in there and it appears to work fine.

I call the component like this: <TilesSkinTile skinUrl="/skins/skin2.png?url" skinName="Test skin 2!" description="This is a test skin!"></TilesSkinTile>

And I created a SkinTile.vue like this: https://pastebin.com/VAh1K2wk

It renders fine, the reset method just doesn't work. Debugging shows that the 'viewerRef' is null. This also happens when only adding the 'TilesSkinTile' once. Could this be an issue on my side?

InstantlyMoist commented 9 months ago

Stupid oversight from me, my bad; I missed the 'ref=viewerRef' part.

so1ve commented 9 months ago

Does it work now? 👀

InstantlyMoist commented 9 months ago

image

Hell yeah! Appreciate the help!

github-actions[bot] commented 8 months ago

This issue has been locked since it has been closed for more than 14 days.

If you have found a concrete bug or regression related to it, please open a new issue. If you have any other comments you should create a new discussion.