search

soanvig / mm-jsr

Range input solution without dependencies
https://soanvig.github.io/mm-jsr
GNU Lesser General Public License v3.0
56 stars 16 forks source link

Development #23

Closed johnnyflinn closed 6 years ago

johnnyflinn commented 6 years ago

Adds redraw method/hack in order to set min/max values. Needed for dynamically generated data where min / max values change.

soanvig commented 6 years ago

The issue is, as I can presume, that You cannot change min/max values after initialising JSR? Because you've changed lots of code and I doubt it's all necessary. I will take a look if it can be done easier.

As far as I can see You did kind of 'refresh' method, I was thinking about that too.

soanvig commented 6 years ago

What I propose is to implement refresh event, and make each module have an action prepared for that event. That makes sense to me: each module then can implement refresh method by itself. Together with refresh, config object will be passed, so that each module can do what it wants.

For now I advise you to use your own implementation. I won't include your PR, however I will today add support for refreshing state of each module (or refreshing state of whole range).

Thank you for contributing.

johnnyflinn commented 6 years ago

No worries. Your implementation will be a lot more stable. I just needed something quick. Look forward to the update.

soanvig commented 6 years ago

PING: I did big refactor, and released new version. Inspired by You! See v1.1.0 and https://github.com/mm-jsr/jsr#refresh I hope it does exactly what You desired.

I tested .refresh() method only with min/max config options for now, but this should be main reason to use that anyway. If we encounter any other potential functionality of that method, we will test it :)

soanvig commented 6 years ago

Damn. I forgot about grid totally. I need to push hotfix!

soanvig commented 6 years ago

It was pretty in hurry, but v1.1.1 is released (because of npm versioning). I've discovered other interesting things by the way, but now it is working.