soanvig / mm-jsr

Range input solution without dependencies
https://soanvig.github.io/mm-jsr
GNU Lesser General Public License v3.0
56 stars 16 forks source link

Is it expected that the npm distribution requires babel plugins etc.. #44

Closed mccainz closed 5 years ago

mccainz commented 5 years ago

I noticed that after adding an NPM dependency for mm-jsr 1.1.15 in my package.json, the corresponding package.lock.json file now has numerous entries for babel-plugin-transform-* related packages required by babel-preset-es2015-rollup as well as an entry for grunt-contrib-copy. Is this expected? Are these actually runtime dependencies or can they be removed?

soanvig commented 5 years ago

This is the bug. Babel preset should not be in dependencies, but in devDependencies. grunt-contrib-copy as well.

Could catch. I'll release corrected version in a while.

soanvig commented 5 years ago

By the way, as stated in README, JSR v1 is legacy, not developed anymore.

See https://gitlab.com/soanvig/jsr/ which is not ready yet, still missing some features from v1, but close to production state.

soanvig commented 5 years ago

Done, 1.1.6 version is published.