Suggestion: include relay url in error object

[antonioconselheiro]

Gm, I would like to suggest to include an attribute in errors thrown in relay, the relay address info.

export class NetworkError extends Error {
  constructor(
    msg: string,
    public relay: WebSocket['url']
  ) {
    super(msg);
  }
}

So you can throw like this:

if (!ok) {
  throw new NetworkError(reason, this.url);
}

https://github.com/soapbox-pub/nostrify/blob/d8afed2c2bd1fc405495dbb8681b4fd1c40f1829/packages/nostrify/NRelay1.ts#L199

You think is make sense?

[alexgleason]

Yes. i almost did it in the first place, but figured I would wait until somebody actually needed it. Mainly because I want to take care how I name this Error class, and where to put it.

[antonioconselheiro]

Good. Knowing the error origin can help users review relay list, by removing relays with more number of errors.