search

soapdog / patchfox

A client for scuttlebutt network as a Firefox WebExtension
MIT License
169 stars 28 forks source link

remove manifest from config system (fixes #69) #70

Closed cryptix closed 4 years ago

cryptix commented 4 years ago

It seems like this was just a left-over since there also is a copy of this file in ./src/core/platforms/ssb/manifest.js

christianbundy commented 4 years ago

I don't work on Patchwork but this LGTM. If you don't have a manifest then SSB-Client will call the manifest() method and download the manifest automatically, which adds a non-zero amount of round-trip latency but I think it's Totally Worth It.

cryptix commented 4 years ago

I don’t think it even needs that but would sure be nicer not to ship a hard-coded one to check incompatibilities early.

soapdog commented 4 years ago

This has been fixed by another commit. Thanks a lot for finding it @cryptix :-)