search

soar-telescope / goodman_pipeline

Goodman Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
15 stars 13 forks source link

Keywords standardization #292

Closed simontorres closed 4 years ago

simontorres commented 5 years ago

Recently some changes to the possible values of certain keywords have been applied to the Goodman HTS' configuration, this is great for automation, however this ensures some problems will arise with the pipelines. Most problems can be quickly fixed, however we will loose backwards compatibility for data reduction. A partial replica of the original message is presented here for documentation/reference purposes.

GRATINGS: Gratings names will always start with the grating lines/mm number, followed by the manufacturer letters, all in capital, and type e.g. 400_SYZY 600_SYZY_BLUE 600_SYZY_OLD 600_SYZY_RED 930_SYZY 1200_RALC_RED 1200_RALC_BLUE 1800_SYZY 2100_SYZY 2400_SYZY

FILTERS:

Filters are described with the following designations, which should always be the same.

u-SDSS g-SDSS r-SDSS i-SDSS z-SDSS VR U B V Rc U-Bessel B-Bessel V-Bessel R-Bessel I-Bessel u-Stromgren v-Stromgren b-Stromgren y-Stromgren

MODES:

All modes are as written in the current masterconfig. The rule is that no white spaces are allowed (therefore there is no need to use " in a name), the only separator allowed is underscore (_), and all names are capitalized. Examples are:

CUSTOM IMAGING 300_ALL 600_UV 600_BLUE 600_MID 600_RED 1200_M0 1200_M1 1200_M2 1200_M3 1200_M4 1200_M5 1200_M6 1200_M7 1200_RESOLVE 400_M1 400_M2 930_M1 930_M2 930_M3 930_M4 930_M5 930_M6 400_WD 930_TP 400_FERMI

LONG SLITS:

Names for long slits also follow similar rules: all names are capitalized, the only separator allowed is underscore (_), so no need for ". The adopted names are the following and should not be changed (naming of multi-object slit masks is flexible): 0.45_LONG_SLIT SLICER B.3 0.6_LONG_SLIT 0.8_LONG_SLIT 1.0_LONG_SLIT OUT_OF_SERVICE 1.2_LONG_SLIT 1.5_LONG_SLIT 3.2_LONG_SLIT 4.0_LONG_SLIT 10.2_LONG_SLIT 0.95_LONG_SLIT N/A SLICER B.4 PINHOLES 1.9_LONG_SLIT

I removed slot names and repeated values, there might be issues with N/A or the SLICER B.3 and SLICER B.4 which does not comply with the rules but they are not used by the pipeline.

simontorres commented 5 years ago

The values <NO FILTER> <NO FILTER> <NO GRATING> <NO MASK> should change to NO_FILTER NO_GRATING NO_MASK

simontorres commented 4 years ago

There are still modifications going on. This issue is not been used as a reference.