soar-telescope / goodman_pipeline

Goodman Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
15 stars 13 forks source link

Fix placeholder wavelength solution to have pixel units instead of Angstroms #322

Closed simontorres closed 4 years ago

simontorres commented 4 years ago

The x-axis should have pixel units. pixel_solutions

simontorres commented 4 years ago

This is not a bug it is just the way splot works. There might be an issue in the future but will not work on it right now.

See the splot documentation regarding units.

UNITS
    The  dispersion  units  capability  of  splot  allows specifying the
    units with the units parameter and interactively changing the  units
    with  the ":units" command.  In addition the 'v' key allows plotting
    in velocity units with the zero point velocity defined by the cursor
    position.

    The  units are specified by strings having a unit type from the list
    below along with the possible  preceding  modifiers,  "inverse",  to
    select  the  inverse  of  the  unit  and "log" to select logarithmic
    units.  For  example  "log  angstroms"  to  plot  the  logarithm  of 
    wavelength  in  Angstroms and "inv microns" to plot inverse microns.
    The various identifiers may be abbreviated as words but  the  syntax
    is  not  sophisticated  enough  to  recognized  standard  scientific 
    abbreviations except as noted below.

               angstroms - Wavelength in Angstroms
              nanometers - Wavelength in nanometers
            millimicrons - Wavelength in millimicrons
                 microns - Wavelength in microns
             millimeters - Wavelength in millimeters
              centimeter - Wavelength in centimeters
                  meters - Wavelength in meters
                   hertz - Frequency in hertz (cycles per second)
               kilohertz - Frequency in kilohertz
               megahertz - Frequency in megahertz
                gigahertz - Frequency in gigahertz
                     m/s - Velocity in meters per second
                    km/s - Velocity in kilometers per second
                      ev - Energy in electron volts
                     kev - Energy in kilo electron volts
                     mev - Energy in mega electron volts

                      nm - Wavelength in nanometers
                      mm - Wavelength in millimeters
                      cm - Wavelength in centimeters
                       m - Wavelength in meters
                      Hz - Frequency in hertz (cycles per second)
                     KHz - Frequency in kilohertz
                     MHz - Frequency in megahertz
                     GHz - Frequency in gigahertz
                      wn - Wave number (inverse centimeters)

    The velocity units require a trailing value and  unit  defining  the
    velocity  zero  point.   For  example to plot velocity relative to a
    wavelength of 1 micron the unit string would be:

            km/s 1 micron

    Some additional examples of units strings are:

            milliang
            megahertz
            inv mic
            log hertz
            m/s 3 inv mic