search

soar-telescope / goodman_pipeline

Goodman Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
15 stars 13 forks source link

Add possibility to manually select Extraction zones #41

Open simontorres opened 7 years ago

simontorres commented 7 years ago

In some very special cases there might happen that the automatic target identification and extraction will not work properly, so there should exist the possibility to, by parsing an argument (most likely), manually select the regions for the target and for background subtraction. This could be particularly helpful for targets that are too close or too close to the border (nobody should put their science target near the border though).

b1quint commented 7 years ago

Isn't this related to #1?

simontorres commented 7 years ago

Absolutely, but I think this can be treated independently because one thing is to improve the target detection (automatically) and another is to add a manual option (similar to the interactive mode for wavelength calibration). Despite this I would consider merging both issues. By the way, this came out from the discussion after the talk in the SOAR 2020 Workshop.

b1quint commented 7 years ago

This is one of the reasons that it has to be considered for the object extraction: if an input from the user may be an option, we have to have the code written to make this available in the future. If not, it may be too entangled so adding this new capability will be much more difficult.

cbaorion commented 7 years ago

Yes, we definitely want this feature! Simon should code things so that this can be added later, but I would not include it for the Beta release.

simontorres commented 7 years ago

It will require some time, since we need to program a graphic user interface for this but if we are planning to create a special library for graphic treatment (see #42 )we better leave the effort for then.

simontorres commented 6 years ago

I'm currently having this issue with data that contains an extended source. Usually the background subtraction zone is selected an n-sigmas apart from the edge of the target extraction zone. What usually works for point sources does not work for extended sources Such as a planetary nebula (LEFT) background-extended-source At least there should be a command line argument that allows to adjust the separation of the background zone.

simontorres commented 5 years ago

Could this be a solution for #13 ? Not for fully automatic.

simontorres commented 5 years ago

related #298

simontorres commented 6 months ago

Upon review with @Allonck we think that despite this issue being very old it is still a desired feature in 2024.