search

soarcn / BottomSheet

One way to present a set of actions to a user is with bottom sheets, a sheet of paper that slides up from the bottom edge of the screen. Bottom sheets offer flexibility in the display of clear and simple actions that do not need explanation.
http://soarcn.github.io/BottomSheet
2.22k stars 408 forks source link

Attribute "bottomSheetStyle" has already been defined #108

Closed stephenmcbride closed 8 years ago

stephenmcbride commented 8 years ago

The latest support library version (23.2.0) adds Google's own variety of BottomSheets and unfortunately there is name clash on the style attribute when you have both libraries as dependencies meaning the app fails to compile.

soarcn commented 8 years ago

Thanks, will fix soon

Malachiasz commented 8 years ago

I am waiting for this fix too. It would be nice of you to point into an article how to migrate your library to the google support library. As for today I cannot find any sample code on the internet.

caioyassoyama commented 8 years ago

Fixed it. Pull request: https://github.com/soarcn/BottomSheet/pull/109

soarcn commented 8 years ago

@Malachiasz good point, but in fact google's bottomsheet is a pattern or container, and this library is an out-of-box component, so there is no easy way to migrate from one to another. But I will find a time to create a demo using google's bottomsheet container.

soarcn commented 8 years ago

PR merged, new release is expected tomorrow.

michgauz commented 8 years ago

Thanks for update :)

Malachiasz commented 8 years ago

@soarcn: if that is so, why do you stop work on this library? It seems not to loose it's reason to exist. Perhaps you could refactor it to use new support's library API, but IMHO it should be still supported. (I have found this article about Google's Bottomsheer: https://medium.com/@nullthemall/new-bottomsheet-caab21aff19b )

soarcn commented 8 years ago

@Malachiasz my plan is to create a reusable view allowing developer to put to google's bottomsheet. In such way, it's not fair to call it bottomsheet anymore. Anyway, for people who satisfy with the UI and functions provided, this library is far more convenient that google's. I'm not saying I will stop working on it, but stop developing new features.

Malachiasz commented 8 years ago

Please release aar with bugfix. The lib is still unusable unless compiled from sources.

caioyassoyama commented 8 years ago

@Malachiasz Version 1.3.0 released and working.

divyenduz commented 8 years ago

Can you please put this in CHANGELOG also ?

soarcn commented 8 years ago

@divyenduz good point, forgot to commit.

stephenmcbride commented 8 years ago

Thanks for fixing this @soarcn :)