search

soarcn / BottomSheet

One way to present a set of actions to a user is with bottom sheets, a sheet of paper that slides up from the bottom edge of the screen. Bottom sheets offer flexibility in the display of clear and simple actions that do not need explanation.
http://soarcn.github.io/BottomSheet
2.22k stars 409 forks source link

gradle build fail with android x and android.enableJetifier=true #142

Closed iam1492 closed 5 years ago

iam1492 commented 6 years ago

When I try migrate to Android X. Gradle build fail from bottomsheet library. And gradle said I have to disable Jetifier option.

KChernenko commented 6 years ago

I have the same problem. Any workarounds?

KChernenko commented 6 years ago

As for now, you can use this fork:

com.github.betterme-dev:BottomSheet:android-x-SNAPSHOT

And add matchingFallbacks = ['debug '] and matchingFallbacks = ['release'] for debug and release build types accordingly.

mikehardy commented 5 years ago

I think .buildscript/deploy_snapshot.sh needs to be altered or something? In order to deploy the aar without the AndroidManifest.xml in it?

soarcn commented 5 years ago

fixed in 1.5.0