soarlab / maline

Android Malware Detection Framework
GNU Affero General Public License v3.0
81 stars 31 forks source link

Remove extraneous assignment in kill-emulator #15

Open mwleeds opened 7 years ago

mdimjasevic commented 7 years ago

Hi @mwleeds,

Thanks for showing interest in maline!

Would you be so kind to describe the pull request?

mwleeds commented 7 years ago

Sure. It appears that everywhere kill-emulator is called the console port is the only argument. The extra assignment to name was probably just accidentally copied over from avd-reload.

By the way, thanks for maline! I just submitted a paper to a conference that made use of it.

mdimjasevic commented 7 years ago

Wow, that's great to hear! Would you say in a sentence or two how you made use of it?

mwleeds commented 7 years ago

I used it to get lists of system calls used by a number of apps, which I then used to train a machine learning model (just a simple TensorFlow softmax one), but it only achieved a classification accuracy of around 60%. Possibly because the sample size was 200 apps. So I think pretty similar to what you did, but with a different ML model and fewer apps. I also looked at a model that was trained on permission requests rather than system calls in the same paper, which had a better accuracy (> 80%).

mdimjasevic commented 7 years ago

I'll take a look at this. It's been a while since we ran maline.