soasis / text

A spicy text library for C++ that has the explicit goal of enabling the entire ecosystem to share in proper forward progress towards a bright Unicode future.
https://ztdtext.readthedocs.io/en/latest/
Other
313 stars 24 forks source link

MAINT: renormalize line endings #35

Closed h-vetinari closed 2 years ago

h-vetinari commented 2 years ago

Like #34, as windows line-endings are creeping in again. Quoting from a comment in that other PR:

I'd recommend that you ensure you have the equivalent of

git config --global core.autocrlf true

to make sure the files don't get messed up again.

If there are particular files that shouldn't be crlf-mangled by git, add them (directly or with a wildcard) to .gitattributes as binary, or specify the eol directly, such as:

*.patch binary
build.sh text eol=lf
build.bat text eol=crlf

Less likely but not impossible, it could be that you have an IDE setting that's overriding this somehow.

ThePhD commented 2 years ago

Yeah, I think VSCode does something messed up regularly to the files during auto-formatting stuff.

Ah, well. Cheers.

h-vetinari commented 2 years ago

Yeah, I think VSCode does something messed up regularly to the files during auto-formatting stuff.

Could be an interaction with https://github.com/microsoft/vscode/issues/96104, but even for that (AFAIU), someone needs to commit CRLF-files into git first.