search

soat-fiap / FIAP.TechChallenge.ByteMeBurger

Repository for FIAP SOAT post degree Tech Challenge
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

refactor: change kubernetes configuration and order status UC #109

Closed italopessoa closed 6 days ago

coderabbitai[bot] commented 1 week ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The changes encompass updates to environment configuration, Kubernetes scripts, and source code dealing with payments and orders. Key modifications include altering environment values, adding Kubernetes secrets and configurations, and updating several methods in the OrdersController and OrderService. The changes also involve returning nullable Payment objects and refining tests to align with the updated functionality.

Changes

File(s) Change Summary
.env.template Updated MercadoPago_WebhookSecret, added MercadoPago_AccessToken and MercadoPago_NotificationUrl.
FIAP.TechChallenge.ByteMeBurger.sln Removed kubernetes\api-hpa.yaml, added kubernetes\secret-mercadopago.yaml and hpa-api.yaml.
docker-compose.yml Added Serilog enrichment configuration.
kubernetes/... Multiple updates: Added MySQL connection string, updated various YAML files for Kubernetes secrets, deployments, and pods.
src/.../OrdersController.cs Removed Checkout method.
src/.../DomainEventsHandler.cs Modified OnOrderPaymentConfirmed to log the entire payload object.
src/.../Program.cs Adjusted logging configuration and AddHealthChecks method.
src/.../OrderService.cs Removed CheckoutAsync method.
src/.../UseCases/Orders Modified methods, commented out RaiseOrderPaymentConfirmed, and updated return types and signatures.
src/.../CreatePaymentUseCase.cs, src/.../ICreatePaymentUseCase.cs, src/.../UpdatePaymentStatusUseCase.cs, src/.../IUpdatePaymentStatusUseCase.cs Changed return types and method signatures to accept/return nullable Payment objects.
src/.../Entities/Payment.cs, src/.../DomainEventTrigger.cs, src/.../OrderPaymentConfirmed.cs Added initialization for Created property, changed method signatures.
src/.../IOrderService.cs, src/.../IPaymentGateway.cs Removed CheckoutAsync, updated CreatePaymentAsync to return nullable Payment object.
src/.../MercadoPagoOptions.cs Allowed NotificationUrl to be nullable.
src/.../MercadoPagoService.cs Updated CreatePaymentAsync to return nullable DomainPayment, added error logging.
tests/... Multiple updates: Removed tests related to checkout, adjusted tests for updated order status logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.