sobisonator / imp19c

Imperator 19th century mod
11 stars 15 forks source link

Governorships going into negative stockpiles during trade #354

Closed sobisonator closed 1 year ago

sobisonator commented 1 year ago

Stockpiles during the trade phase have more tradegoods deducted from some stockpiles than is available.

The intended behaviour is that the governorship should only have as much deducted as it has offered to sell to the market.

Try looking at the amount made available to the market that quarter, which should indicate the amount that should have been subtracted from the stockpile if the sale was made correctly.

To recreate this bug, run event debug_trade.1 and then event debug_trade.2 then inspect the stockpiles of governorships for negatives.

sobisonator commented 1 year ago

Some work on this here... https://github.com/sobisonator/imp19c/commit/169d3bd69617a3a026731c7b8b3bc70587a9f745

sobisonator commented 1 year ago

Fixed by https://github.com/sobisonator/imp19c/commit/169d3bd69617a3a026731c7b8b3bc70587a9f745