search

sobisonator / imp19c

Imperator 19th century mod
11 stars 15 forks source link

Update price calculation for trade method merge #395

Open sobisonator opened 1 year ago

sobisonator commented 1 year ago

Merging the trade methods: new dynamic demand and old stockpile-based trade.

Will need to rework the way demand is calculated for the merge of trade methods Demand is currently being calculated in the new way, so demand for goods with substitutes (foods, luxuries) is 0 at game start and only gets calculated once effects run, whereas in the old way the global price is set using an arbitrary demand value.

sobisonator commented 1 year ago 
Error: Failed to fetch variable for 'global_price_vegetables' due to not being set
  Script location: file:  file:  file:  file:  file:  file:  file: events/DEBUG/debug_trade.txt line: 12; TRADE_prepare_quarterly_values line: 3; TRADE_update_all_TZ_local_prices line: 4; every_tradegood_complex line: 1; every_type_complex line: 2; tradegood_hypercomplex line: 197; SELL_set_TZ_prices line: 2

It seems that this error is being caused by a number of DEMAND_$tradegood$ svalues being 0 at game start because they are waiting for the calculations from the static-trade system to run

My suggestion to smooth this over for now is to create an else condition in the svalues that sets DEMAND_$tradegood$ svalues to 10 in every governorship.

sobisonator commented 1 year ago

More or less resolved at this point: commit https://github.com/sobisonator/imp19c/commit/454f16941f62aa6dc538cdc2b4088a0666d79145

Will close when merging