search

sobjornstad / tzk

Zettelkasten edition and tooling for TiddlyWiki
https://sobjornstad.github.io/tzk/
MIT License
43 stars 10 forks source link

Missing `KillPhrases` file in build process #14

Open MatHazak opened 2 months ago

MatHazak commented 2 months ago

I believe the KillPhrases tiddler should be transferred to the main tiddlers/ directory because builders.py looks for it there. https://github.com/sobjornstad/tzk/blob/b8187ce0e888ce05709e2147f006f1ffabd10735/tzk/builders.py#L196-L197 It doesn't get transferred from tiddlers/_system/config/zettelkasten/Build/KillPhrases.tid to tiddlers/$__config_zettelkasten_Build_KillPhrases.tid until the tiddler is edited, which causes a missing file error during the build process.

sobjornstad commented 2 months ago

I think yielding a missing file error if you have not configured any kill phrases is the correct behavior. Given the nature of kill phrases, I would want it to tell me that I had set it up incorrectly, rather than believing that I had configured kill phrases when the file actually wasn't in the right place / populated.

I'll delete the empty _system/config/zettelkasten/Build/KillPhrases.tid file in future releases instead of blanking it out, that was just an oversight (I copied this config from the public build).

MatHazak commented 2 months ago

I see your point. I think a more detailed error message could help reduce the confusion that some users may face. Thanks for your consideration.