Closed joshrabinowitz closed 6 years ago
Note: revert changes in https://github.com/sobolevn/git-secret/pull/181/commits/f2214bde6fc2fbf97b82b1e0a52ffd0d95d7bec5
Looking hard into this I cannot spot any difference with the built deb file and teh install commands so I asked on stackexchange: https://unix.stackexchange.com/questions/448659/manual-pages-of-built-deb-install-on-debian-but-not-ubuntu
you might want to upvote it so that more eyes get to look at it!
Somone supplied the fix! Its probably going to a few hours before I can next run the test suite but it looks to be something like adding a check and remove of /etc/dpkg/dpkg.cfg.d/excludes
such as:
# Building .deb package:
if [ -f /etc/dpkg/dpkg.cfg.d/excludes ]; then
rm /etc/dpkg/dpkg.cfg.d/excludes
fi
cd "$SCRIPT_DEST_DIR" && build_package "deb"
Are there other paths listed in /etc/dpkg/dpkg.cfg.d/excludes ?
And perhaps we should do something less severe than just deleting that file?
It just blocks /usr/share/man/ and and /usr/share/doc/
kitchen@ceddd8d3564c:~$ grep -r path-exclude /etc/dpkg/dpkg.cfg /etc/dpkg/dpkg.cfg.d/excludes:path-exclude=/usr/share/man/ /etc/dpkg/dpkg.cfg.d/excludes:path-exclude=/usr/share/doc/*
If we are testing "do we build a valid deb" then the answer is "yes". If we are testing "do we know how users install into /usr/share/man when that is now blacklisted on ubuntu?" then the answer is "no". I think we should release the code and then figure out that as a separate issue.
Running one ubuntu ci test locally the fix works. About to send a PR.
Just to be clear I don't think my server change is about blatting anyone's machine. The change which I just sent over as a PR is run as root as ci test setup where the .deb
is built to test it. So at that point, I remove the blacklist so that the .deb
can be tested.
Correction It is better to remove the /etc/dpkg/dpkg.cfg.d/excludes
in ansible.
I have moved this into ansible on my latest PR.
fixed in #188
See https://travis-ci.org/sobolevn/git-secret/jobs/378803909 and https://travis-ci.org/sobolevn/git-secret/jobs/378803908