search

sobolevn / git-secret

:busts_in_silhouette: A bash-tool to store your private data inside a git repository.
https://sobolevn.me/git-secret/
MIT License
3.73k stars 198 forks source link

Add `CentOS` to the containers list in `.docker/rpm` #38

Closed sobolevn closed 6 years ago

sobolevn commented 8 years ago

It is just pretty much the same as fedora one. It is also needed to add it to the .tavis.yml to be tested.

sobolevn commented 8 years ago

See: https://github.com/sobolevn/git-secret/blob/develop/.docker/rpm/fedora/Dockerfile And: https://travis-ci.org/sobolevn/git-secret/builds/138178890

sobolevn commented 7 years ago

See this job https://travis-ci.org/sobolevn/git-secret/jobs/205525427

sobolevn commented 7 years ago

I guess it can be related to this bug: https://github.com/sobolevn/git-secret/issues/46 gpg version needs to be checked.

hurricanehrndz commented 7 years ago

@sobolevn,

I would close this. In order for CentOS to be supported appropriately it needs a git version that is newer than the one available. If you wish to have CentOS supported the _check_ignore function would need to be re-written as to not use features introduced in version 1.8.5/1.9. Current version is 1.8.3.