Adobe RGB - Githubissues

sobotka / filmic-blender

Film Emulsion-Like Camera Rendering Transforms for Blender

https://sobotka.github.io/filmic-blender/

2.07k stars 147 forks source link

Adobe RGB #17

Open bjorn3 opened 7 years ago

bjorn3 commented 7 years ago

Please support conversion to Adobe RGB.

sobotka commented 7 years ago

It is on the TODO. Sadly they are display referred, but I will support the transform.

Eneen commented 6 years ago

Any news on this?

sobotka commented 6 years ago

It will likely be added in the next wider gamut iteration, but not into this repository. The stanzas shouldn't be too difficult to design for those keen.

Eneen commented 3 years ago

Just a reminder, when to expect this?

sobotka commented 3 years ago

For input or display?

Eneen commented 3 years ago

I think both.

sobotka commented 3 years ago

You “think”? What is your context? Are you loading AdobeRGB imagery or do you have an AdobeRGB display?

Eneen commented 3 years ago

I'm using adobergb display (dell u2713h) and have some textures in adobergb, own made backplates mainly. They are currently converted into srgb ofc.

sobotka commented 3 years ago

OCIO v1 doesn’t provide a clean mechanism to clip out of gamut values, so you’ll need to take that into account in your own pipeline. Give me a few...

Eneen commented 3 years ago

Do you also plan to add Rec.2020 and DCI-P3? I don't use them but looks like they will be needed at some point.

sobotka commented 3 years ago

I'm not too concerned with things that people don't have or aren't using exclusively yet. It requires actual people with actual needs and hardware to test.

Please test https://github.com/sobotka/filmic-blender/tree/with-AdobeRGB

Eneen commented 3 years ago

Pure AdobeRGB works, but Filmic Log View Transform doesn't, on both sRGB and Adobe. I've checked master branch and it works ok there, for sRGB ofc. On a daily basis I use config distributed with blender and I see that input color space naming has changed:

Non-Color is now Non-Color Data
sRGB is now sRGB OETF This way all maps are now switched into sRGB OETF. This is quite a problem with non-color maps like normals and roughness as it requires manual adjustment of all non-color maps in all current projects. Is it possible to keep previous names, just "sRGB" and "Non-Color"?

sobotka commented 3 years ago

Aliases are a part of OCIO v2. I’m not mangling up this config to appease Blender poor design choices. Other folks using other software use it too.

There are specific roles that are set and Blender should honour, but that’s on Blender.

https://github.com/sobotka/filmic-blender/blob/master/config.ocio#L22

What is wrong with the AdobeRGB Filmic Log specifically?

Eneen commented 3 years ago

For both sRGB and AdobeRGB Filmic log doesn't work, nothing happens when I switch into. Even greyscale doesn't work.

sobotka commented 3 years ago

Odd. It worked when I tested it. Will check when I have a moment later.

Eneen commented 3 years ago

Ah, my bad, looks like it works fine. Take a look @ line 52, shouldn't be AdobeRGB there? And line 199 in description, same thing.

sobotka commented 3 years ago

Good spot. The AdobeRGB wasn’t working obviously, due to being Apple’s Display P3. Give it a test. This is untested as I committed the fixes via the browser.