sobotka / filmic-blender

Film Emulsion-Like Camera Rendering Transforms for Blender
https://sobotka.github.io/filmic-blender/
2.07k stars 147 forks source link

filmic Blender 2.8 #56

Open rrafeiteira opened 4 years ago

rrafeiteira commented 4 years ago

Is there a way to use filmic blender on blender 2.8?

sobotka commented 4 years ago

The default “Filmic” is it. To use this repository, set an environment variable or replace the directory. The environment variable setting technique would be something similar to export OCIO=/path/to/the/config.ocio.

mrmowgli commented 4 years ago

@sobotka So is this already in 2.8? Or is this something else? If it is meant as a replacement for the existing 2.8 Filmic set, perhaps there should be something in the README.md file explaining the difference?

sobotka commented 4 years ago

It’s a different configuration, as is clear. Not sure that it requires further explanation?

mrmowgli commented 4 years ago

The core of it is that since 2.8 (And I saw the issue for the 2.79 branch as well) of Blender include their own set of transforms also named Filmic, and including ACES. It wasn't clear at least to me if at some point they had revised anything for 2.8, possibly merging in your set. Perhaps a simple paragraph explaining that this relates to the current versions as well, assuming that the color profiles in 2.8 are still lacking. It is probably less clear for those of us just now trying to set up our pipelines with Blender than those who have been tracking this for a while.

sobotka commented 4 years ago

The core of it is that since 2.8 (And I saw the issue for the 2.79 branch as well) of Blender include their own set of transforms also named Filmic, and including ACES.

It’s borrowed bits, just like the entirely broken ACES bits in official that should be removed.

It wasn't clear at least to me if at some point they had revised anything for 2.8, possibly merging in your set.

It’s pretty clear that it’s a different configuration entirely, no?

Perhaps a simple paragraph explaining that this relates to the current versions as well, assuming that the color profiles in 2.8 are still lacking.

It’s a different configuration again, as is pretty painfully clear? It isn’t on me to track what people do and modify in their configurations.

It is probably less clear for those of us just now trying to set up our pipelines with Blender than those who have been tracking this for a while.

Not sure how it isn’t clear when one has different transforms compared to the other?

mrmowgli commented 4 years ago

Sure, it's more obvious when you dig into it a bit more, but I had to read through your posts on StackExchange to get a gist of what this set is. The assumption is that everyone coming to this repo are already familiar with all of the transform types and know what the differences are.

sobotka commented 4 years ago

I just don't think it is worth worrying about how some other thing does something. I'd end up tracking changes and trying to make a list, or just say "This is different", which should be self evident. If it isn't self-evident for a given audience member, they likely don't find themselves using the repository.

echuber2 commented 4 years ago

I think it is not self-evident to people who are discovering this repo for the first time, especially since the name confusion may make it appear to be a branch that is actually part of the main Blender project, just as some projects do regularly pull in work from other repos as part of their own. I'm thinking of for example, how gitk is incorporated into git. There would be little harm in adding one sentence to the readme to dispel that illusion explicitly. It's just a suggestion.

sobotka commented 4 years ago

It is a nuanced question.

If it weren’t different, why on earth would it exist? With that said, if someone can’t identify what is different or why they are here in the first place, they are definitely outside of the target audience in the first place, and no amount explanation is going to help them.

Read the readme. It’s all there.

Haprog commented 4 years ago

I think it would be beneficial to make it very clear in the readme that the default "Filmic" in new Blender is still not the same as this repo and that there are still benefits in using this repo.

Personally I just started learning Blender a few days ago and pretty quickly stumbled upon a YouTube video recommending this filmic-blender repo and I installed it before I had even ever rendered anything in Blender.

But after installing Blender on another computer I just today noticed that Blender already has a "Filmic" by default and I was confused and had to google is it the same thing now (did Blender include this repo by default already?) or should I still install the version from this repo or not.

And that's why I found this issue.

g-e-r commented 4 years ago

Same, I couldn’t find out how this it different/better/worse than default blender 2.8 Configuration.

I’d suggest to at least update the “Why” section with a reference to 2.8. This configuration is a step towards providing imagers with a reliable camera rendering transform does not seem to apply to 2.8, as 2.8 already has a reliable camera rendering transform by default - right?

Maybe just mention that, blender 2.8 provides OpenColorIO configuration by default and filmic blender is a better taste of it...

sobotka commented 4 years ago

Again, there are a few things that are self evident for people who find themselves here. Compare the displays.

ricardomatias commented 4 years ago

@sobotka There's far less effort in adding a small paragraph than going back and forth why it's evident this is different from what Blender provides.

sobotka commented 4 years ago

All of the information is in the readme.

skarkkai commented 3 years ago

Most people will not read more of the README than they feel necessary for their immediate goals. That's the truth for any and all software.

sobotka commented 3 years ago

Then perhaps they are the wrong audience.