sobotka / filmic-blender

Film Emulsion-Like Camera Rendering Transforms for Blender
https://sobotka.github.io/filmic-blender/
2.07k stars 141 forks source link

"Non-color" is spelled as "Non-colour Data" in the addon which interferes with object importing. #68

Open DolbaebTuporiliy opened 3 years ago

DolbaebTuporiliy commented 3 years ago

When importing an object Blender tries to look for the "Non-color" in the code, but because of the addon it can not find it so it fails to import any object. This can be easily fixed by config.ocio with a notepad and changing "Non-colour Data" to "Non-color".

Michaelknubben commented 3 years ago

Having just had an issue with files saved with Filmic Blender and opened in regular 2.92: I think this issue also applies to those. Students had saved their files with normal/roughness/etc maps set to 'Non-color', and when opened in a default Blender install those were all set to sRGB again.

Could this be related?

TheDuckCow commented 2 years ago

I just happened to come across this, I'm an addon developer and have needed to write code workarounds to the bug caused by this issue in multiple different repositories (true this would apply to any other colorspaces with different names, to be fair).

A bit late at this point, if this change was committed, it would indeed fix both built in operators in blender and many addons for anyone who tries to install filmic this way going forward.