search

sobotka / olive

NLE video editor
GNU General Public License v3.0
2 stars 1 forks source link

[PIXELS] Default Node Color Values incorrectly Rounded by Properties #143

Open ThomasWilshaw opened 3 years ago

ThomasWilshaw commented 3 years ago

The values stored in config.xml for the Node Colors are being corrupted somewhere. Compare the value in config.xml to the values that are set by the Config. If I delete all the node color entries from the config file and then open and close Olive, they are all re saved as the correct value. If I then open Olive, go to Preferences (not even the Appearance tab specifically) and then close Olive, they've all been re saved as the incorrectly rounded value.

This may just be a rounding problem somewhere or may point to something going wrong in the pixel pipeline.

Values in my config.xml:

    <NodeCatColor0>0.749996:0.749996:0.749996:1</NodeCatColor0>
    <NodeCatColor1>0.250004:0.250004:0.250004:1</NodeCatColor1>
    <NodeCatColor2>0.749996:0.749996:0.250004:1</NodeCatColor2>
    <NodeCatColor3>0.749996:0.250004:0.749996:1</NodeCatColor3>
    <NodeCatColor4>0.250004:0.749996:0.749996:1</NodeCatColor4>
    <NodeCatColor5>0.500008:0.500008:0.500008:1</NodeCatColor5>
    <NodeCatColor6>0.250004:0.749996:0.250004:1</NodeCatColor6>
    <NodeCatColor7>0.250004:0.250004:0.749996:1</NodeCatColor7>
    <NodeCatColor8>0.749996:0.250004:0.250004:1</NodeCatColor8>
    <NodeCatColor9>0.549996:0.549996:0.749996:1</NodeCatColor9>

Values in Config.cpp:

 SetEntryInternal(QStringLiteral("NodeCatColor0"), NodeParam::kColor, QVariant::fromValue(Color(0.75f, 0.75f, 0.75f)));
  SetEntryInternal(QStringLiteral("NodeCatColor1"), NodeParam::kColor, QVariant::fromValue(Color(0.25f, 0.25f, 0.25f)));
  SetEntryInternal(QStringLiteral("NodeCatColor2"), NodeParam::kColor, QVariant::fromValue(Color(0.75f, 0.75f, 0.25f)));
  SetEntryInternal(QStringLiteral("NodeCatColor3"), NodeParam::kColor, QVariant::fromValue(Color(0.75f, 0.25f, 0.75f)));
  SetEntryInternal(QStringLiteral("NodeCatColor4"), NodeParam::kColor, QVariant::fromValue(Color(0.25f, 0.75f, 0.75f)));
  SetEntryInternal(QStringLiteral("NodeCatColor5"), NodeParam::kColor, QVariant::fromValue(Color(0.50f, 0.50f, 0.50f)));
  SetEntryInternal(QStringLiteral("NodeCatColor6"), NodeParam::kColor, QVariant::fromValue(Color(0.25f, 0.75f, 0.25f)));
  SetEntryInternal(QStringLiteral("NodeCatColor7"), NodeParam::kColor, QVariant::fromValue(Color(0.25f, 0.25f, 0.75f)));
  SetEntryInternal(QStringLiteral("NodeCatColor8"), NodeParam::kColor, QVariant::fromValue(Color(0.75f, 0.25f, 0.25f)));
  SetEntryInternal(QStringLiteral("NodeCatColor9"), NodeParam::kColor, QVariant::fromValue(Color(0.55f, 0.55f, 0.75f)));