search

sobotklp / conan-rabbitmq-c

Conan.io package for RabbitMQ C/C++ library
MIT License
2 stars 3 forks source link

Windows build #1

Open db4 opened 6 years ago

db4 commented 6 years ago

Did you ever try to build it with Visual Studio? I have numerous problems there.

sobotklp commented 6 years ago

Unfortunately I haven't tried building on Windows. That's a missing piece for all of my Conan packages.

db4 commented 6 years ago

I have made a fork and fixed all issues there. I you find it useful I can submit PR to your repo.

sobotklp commented 6 years ago

I'd very much appreciate a PR! Thanks for doing that work!

db4 commented 6 years ago

Done: https://github.com/sobotklp/conan-rabbitmq-c/pull/2

Are you planning to contribute the package to conan-center?

sobotklp commented 6 years ago

I'll certainly contribute to conan-center if this recipe is up to their quality standards. Do you think I should submit? I can't guarantee I'll be a reliable maintainer, unfortunately :(

db4 commented 6 years ago

I believe the recipe is currently good enough. All major OSes/architectures are supported, CI status is green, not much maintenance is expected. I think you definitely should. Maybe just add Appveyor status like I did in my README.md?

I also have a companion recipe for SimpleAmqpClient library, created by the same author as rabbitmq-c. If rabbitmq-c is accepted by conan-center, I will submit my recipe as well.