Demo apps don't compile anymore

sobri909 / MGBoxKit

Simple, quick iOS tables, grids, and more

Other

1.79k stars 283 forks source link

Demo apps don't compile anymore #126

Closed skrew closed 10 years ago

skrew commented 10 years ago

Hi,

With the split of MGEvents, the demo apps don't compile when you simply git clone

sobri909 commented 10 years ago

Ah true. Actually I'd assumed they stopped compiling much earlier than that, due to various backward compat breaks. They desperately need updating to demonstrate the new box provider stuff too.

PaitoAnderson commented 10 years ago

As of e205c0917e0f477ab8af7ba1b48a8254db9da775 it should compile without any errors or warnings.

Update to the latest version.
In a terminal cd Demo\ App and pod install
Open Demo App\MGBoxKit Demo.xcworkspace in Xcode.

sobri909 commented 10 years ago

Thanks @PaitoAnderson!

skrew commented 10 years ago

Thanks @PaitoAnderson, but the demo have bugs, like:

MGLineStyled *line1 = [MGLineStyled multilineWithText:waffle1 font:nil width:304 padding:UIEdgeInsetsMake(16, 16, 0, 16)];

All examples called with font:nil will crash in easySizeWithFont

Quickfix: Just replace all font:nil with font:HEADER_FONT

PaitoAnderson commented 10 years ago

Thanks @skrew, I have submitted a PR for this #130.