search

soburi / openthread_nrf52_arduino

A Arduino package for nRF52 that integrated with OpenThread
Other
18 stars 3 forks source link

Add support for Makerdiary nRF52840 MDK dongle #46

Open Brezensalzer opened 2 years ago

Brezensalzer commented 2 years ago

Digital Pins, I2C, SPI, Serial (USB) and OpenThread was successfully tested. Thank You for Your support!

soburi commented 2 years ago

@Brezensalzer Could you push this patch into the upstream repository ?

This PR is useful for not only my openthread enabled arduino. so It is better to push upstream.

(In actual, I maintain this project with mainly merge upstream updates only. It will keep world peace if you push to upstream project. :-)

I wrote any I noticed to the PR review.

Brezensalzer commented 2 years ago

Hello soburi, when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that. I have also fixed the analog pin definition.

This PR is useful for not only my openthread enabled arduino. so It is better to push upstream.

You have a point there. I will make a pull request on the upstream Adafruit repository. Thank You for Your support!

soburi commented 2 years ago

@Brezensalzer ,

You have a point there. I will make a pull request on the upstream Adafruit repository.

That's good! Since I'm watching the upstream repository, I will quickly apply the changes once it merges into the upstream.

when using CircuitPython the board enumerates with vid 0x239A and pid 0x80DD, so I've used that.

hmm... I think it's better to remove it. (I'm not sure if the CircuitPython package supports a 'use_1200bps_touch' to flash. It is good to consult to upstream project when push.)