search

soc-hub-fi / headsail-vp

Headsail — Virtual Platform
0 stars 3 forks source link

Fix minor issues in DLA driver #56

Closed hegza closed 3 months ago

hegza commented 4 months ago

Started by looking at the option thing discussed in a recent PR, ended up fixing a bunch of warnings.

hegza commented 4 months ago

Check especially this commit which has the Option thing I mentioned in a recent PR: https://github.com/soc-hub-fi/headsail-vp/pull/56/commits/a84e9a4437369c73519f5cbd8cb8c1541abbc36b.

There was an extra parameter on get_banks_for_layer that wasn't used for anything, except for the side-effect that the type had a method capable of producing an option. You can also produce an option by just wrapping it in Some(_).

hegza commented 4 months ago

I noticed also that there was a little bit of a warning drown going on. It may be difficult to tell when there's a useful warning, when there's dozens of superfluous ones, therefore I took a stance and disabled dead_code for mmio.rs and fixed all the trivial ones.

I do generally recommend getting rid of dead_code altogether (e.g., unused functions). If you need them back later, use version control.