search

soc221b / vue-next-select

The selecting solution for Vue 3
https://iendeavor.github.io/vue-next-select
MIT License
86 stars 20 forks source link

Close on select not working when upgrading from 2.5 to 2.6 #219

Closed eboye closed 1 year ago

soc221b commented 3 years ago

@eboye It works for me. Could you please provide more details or a reproduce link?

I have create the following sandbox for this issue, you could fork it.

To Reproduce A reproduce link: https://codesandbox.io/s/vue-next-select-issue-219-ppizx?file=/src/views/BasicUsage.vue

Steps to reproduce the behavior:

  1. Go to Basic Usage.
  2. Click on select.
  3. Click on first option.

Expected behavior Select should be closed.

eboye commented 3 years ago

Hmm, I kind of fixed it ... I was not using CSS from the package but replicated it in my own scss so it could be styled with the design of the application.

Have you altered your css and possibly the way the dropdown is shown/hidden?

It would be helpful if you could provide this kind of "breaking changes" in the release notes.

soc221b commented 3 years ago

Thank you for your reply.

I think it is caused by this commit.

But I need to consider whether I should revert it and whether it is a BREAKING CHANGE 🤔 .

eboye commented 3 years ago

Yup, that's the one :D

I've added this to make it work image

As I'm using tailwind in my project I've extracted all the css from all (not many) libraries to the scss so the css footprint could be lower.

soc221b commented 3 years ago

Are the datasets and a11y attributes sufficient for all of your use case?

BTW, I would recommend you to change .vue-dropdown[data-is-focusing='false'] to .vue-select[aria-expanded='true'] vue-dropdown since the second one is more formal, and I will remove some dataset (if it can also be detect by aria-* attributes) in next major version too.

eboye commented 3 years ago

Yup they are, I just needed something to easily style the select and have it work with keyboard navigation and not do everything from scratch as I'm using tailwind and very little plugins ...

Sure, I'll switch to aria attrs. Good point.