search

socallinuxexpo / scale-drupal

SCALE's drupal website and related configs
1 stars 3 forks source link

why dont we return 404s for */speakers/* */sponsors/* */presentations/* pages? #103

Open irabinovitch opened 11 months ago

irabinovitch commented 11 months ago

We dont seem to return 404 not found for pages in most case.

Any random string after /speakers, /sponsors/, /blog/, /presentations/, etc results in a page being rendered with content.

For example, I'd expect this to 404 but instead it returns the full list of speakers: http://www.socallinuxexpo.org/scale/13x/speakers/twitter.com/dontrebootme

Similarly https://www.socallinuxexpo.org/blog/this/is/not/a/real/url/ returns the content of /blogs/

Not a big deal, but looking at logs theres a constant stream of crawlers/bots just recursively looping over these non-existent pages. these pages are surprisingly expensive to generate from a memory standpoint. would be nice to just return a cheap/static "not found" page as well as proper 404 response code.

I also thinks this masks various bugs we have with speaker pages, which would be easier to find if we got a proper error.

DrupalPhil commented 11 months ago

Views in Drupal 7 just doesn't work that way.

Extra path components (separated by slashes) are ignored if they don't match a more specific menu entry. So if you have a menu entry for path xxx/yyy it'll also receive requests for xxx/yyy/zzz and xxx/yyy/zzz/aaa.

We can add logic either at the server-lever or in the code to redirect these additional params to the canonical but we'd need to do it on a case by case basis.

sbibayoff commented 11 months ago

Sorry to reopen, I just wanted to add a footnote to this issue. Can't do this easily on Drupal 7, but this is easily achievable in Drupal 8: https://www.drupal.org/project/force404

Hopefully migration happens by 22x, Steve

On Tuesday, October 3, 2023, Phillip Smith @.***> wrote:

Closed #103 https://github.com/socallinuxexpo/scale-drupal/issues/103 as completed.

— Reply to this email directly, view it on GitHub https://github.com/socallinuxexpo/scale-drupal/issues/103#event-10545068854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASGFLMDEVC4IT46VS3MYUTX5S46XAVCNFSM6AAAAAA4Y3K6WGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQGU2DKMBWHA4DKNA . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

DrupalPhil commented 11 months ago

Good find. I'll take a look and see if it breaks anything first.