socallinuxexpo / scale-drupal

SCALE's drupal website and related configs
1 stars 3 forks source link

Add additional fields to CFP Reviewer view of presentations #86

Closed irabinovitch closed 1 year ago

irabinovitch commented 1 year ago

opening this for @kcbraunschweig.

CFP Reviewers would like to be able to see the following additional views when logged in and looking at a presentation page:

Today we only show a subset.

We don't want comments visible to the general unauthenticated public. Only people with the right role who are logged in.

irabinovitch commented 1 year ago

@kcbraunschweig i think this is done.

kcbraunschweig commented 1 year ago

I can only confirm this on 20x and only on talks that are unpublished but that is probably as intended. I think this looks good. Will reopen if it doesn't show up as expected once we have

kcbraunschweig commented 1 year ago

This is weird, to try to test this I tried to create a test submission to the 21x cfp. 21x is in the drop down and was selected, however after submitting successfully it saves as: https://www.socallinuxexpo.org/scale/19x/presentations/kc-test-1 Clearly under 19x. Not sure whats up with that. Also I can't use this to validate the change because its my submission so I see the owner view not the voter view.

irabinovitch commented 1 year ago

@DrupalPhil thoughts?

kcbraunschweig commented 1 year ago

I think what I hit was an example of https://github.com/socallinuxexpo/scale-drupal/issues/64 Gonna close this issue as the additional fields seem to be there which was the point of this issue.