[READY] - gha: removing set-output due to deprecation - Githubissues

socallinuxexpo / scale-network

SCaLE's on-site expo network configurations, wifi, tooling, and scripts

https://www.socallinuxexpo.org/

BSD 3-Clause "New" or "Revised" License

40 stars 16 forks source link

[READY] - gha: removing set-output due to deprecation #629

Closed sarcasticadmin closed 8 months ago

sarcasticadmin commented 9 months ago

Description of PR

Fixes: https://github.com/socallinuxexpo/scale-network/issues/610

Relates to: #611 (python3 removal)

More deprecations from gha, specifically set-output: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Previous Behavior

trigger workflow uses set-output
Checking for python3, and zabbix in serverspec tests

New Behavior

trigger workflow uses $GITHUB_OUTPUT
removed serverspec tests that were checking for binaries/services that are no longer present

Tests

[x] Working Case - Trigger Test: https://github.com/socallinuxexpo/scale-network/pull/629#discussion_r1385966499
- result: https://gitlab.com/socallinuxexpo/scale-network/-/jobs/5484332703
[x] Fail Case - Trigger Test: https://github.com/socallinuxexpo/scale-network/pull/629#discussion_r1385926925
- result: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1064632364
- Confirmation that variables are propagating with gha output updates:
```
{"ref":"rh/1696716150gha","variables":{"OPENWRT_INTEG":"YES","WORMHOLE_CODE":"tony-1-hello"},"id":"17362342"}
```

github-actions[bot] commented 9 months ago

[RUNNING] - Successfully triggered gitlab flash pipeline:

gitlab pipeline: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1029093092

github-actions[bot] commented 8 months ago

[RUNNING] - Successfully triggered gitlab flash pipeline:

gitlab pipeline: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1064632364

github-actions[bot] commented 8 months ago

[RUNNING] - Successfully triggered gitlab flash pipeline:

gitlab pipeline: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1064637761

github-actions[bot] commented 8 months ago

[RUNNING] - Successfully triggered gitlab flash pipeline:

gitlab pipeline: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1064651243

github-actions[bot] commented 8 months ago

[RUNNING] - Successfully triggered gitlab flash pipeline:

gitlab pipeline: https://gitlab.com/socallinuxexpo/scale-network/-/pipelines/1064660848