Rename gha workflow to match existing functionality - Githubissues

socallinuxexpo / scale-network

SCaLE's on-site expo network configurations, wifi, tooling, and scripts

https://www.socallinuxexpo.org/

BSD 3-Clause "New" or "Revised" License

46 stars 19 forks source link

Rename gha workflow to match existing functionality #630

Closed sarcasticadmin closed 7 months ago

sarcasticadmin commented 11 months ago

Description

Currently we have validate-datafiles.yml: https://github.com/socallinuxexpo/scale-network/tree/4699e5e24d6dc3fe9dfc137c83218290ad84c322/.github/workflows but this contains not only the pytest for validation but additional tests to leverage the nix job cache. This results in our entire CI running in under 60 seconds for every change vs have to specify the paths like our previous CI workflows.

Given how expressive we can be via the tests inside the our nix configuration: https://github.com/socallinuxexpo/scale-network/blob/4699e5e24d6dc3fe9dfc137c83218290ad84c322/nix/tests/flake-module.nix I dont see much need for separate CI workflows and the typical features you would require for a workflow.

I would purpose we move rename validate-datafiles.yml to ci.yml or something generic and just continue to add out runs to the single job.

Acceptance Criteria

ci.yml contains all ci jobs that we have

owendelong commented 8 months ago

Seems reasonable to me... Please make it so and close issue.