Closed kylerisse closed 5 months ago
@sarcasticadmin I'm happy with this and can mark as ready. I left as WIP in case you want to pull it down and test via nix build -L .#checks.x86_64-linux.pytest-facts
just in case there is some kind of versioning issue that I can't recreate. Also, let me know if this output is what you're looking for. All I did was leverage python's __name__
since our validation functions are pretty well named already and keeps things simple.
Fixes #480
Description of PR
Updates data validation to be more verbose.
Previous Behavior
New Behavior
Tests
Locally:
test_datasources.py::test_aplist_csv FAILED [ 20%] test_datasources.py::test_pilist_csv PASSED [ 40%] test_datasources.py::test_routerlist_csv PASSED [ 60%] test_datasources.py::test_serverlist_csv PASSED [ 80%] test_datasources.py::test_switchtypes_tsv PASSED [100%]
====================================================================================== FAILURES ======================================================================================= _ test_aplistcsv
test_datasources.py:28: AssertionError =============================================================================== short test summary info =============================================================================== FAILED test_datasources.py::test_aplist_csv - AssertionError: invalid field 173 failed isvalidwifi5chan at line 1 of ./aps/aplist.csv ============================================================================= 1 failed, 4 passed in 0.02s =============================================================================