The ansible code was last used during Scale 19x. Its remained in the codebase for reference and still had some usable tests for inventory.py. I think this is a good time to clean up this part of the codebase to make it clearer to the rest of the team what parts of the repository are actually being utilized.
Previous Behavior
ansible dir in the repo
test_inventory.py was not being utilized by existing CI
Off by 1 calculation for dhcp4range of /21
New Behavior
ansible dir removed and removed most references to ansible in the repo
test_inventory.py moved over to facts and incorporated into existing CI
All tests in test_inventory.py have been updated for latest functionality of inventory.py
Off by 1 calculation fixed for dhcp4range
Tests
All tests from test_inventory CI tests are passing
Description of PR
The ansible code was last used during Scale 19x. Its remained in the codebase for reference and still had some usable tests for inventory.py. I think this is a good time to clean up this part of the codebase to make it clearer to the rest of the team what parts of the repository are actually being utilized.
Previous Behavior
ansibledir in the repoNew Behavior
ansibledir removed and removed most references to ansible in the repotest_inventory.pymoved over tofactsand incorporated into existing CItest_inventory.pyhave been updated for latest functionality ofinventory.pyTests
test_inventoryCI tests are passing