Add checks for duplicate data to switch-configuration data files

socallinuxexpo / scale-network

SCaLE's on-site expo network configurations, wifi, tooling, and scripts

https://www.socallinuxexpo.org/

BSD 3-Clause "New" or "Revised" License

40 stars 16 forks source link

Add checks for duplicate data to switch-configuration data files #739

Open kylerisse opened 3 months ago

kylerisse commented 3 months ago

Description

Had concerns that the current pytest based data validation only addressed individual fields and didn't have any insight into duplicate data throughout an entire file. This was addressed in this PR. This PR only addressed the files in /facts but not yet for switch-configuration/config. That needs to be added.

Acceptance Criteria

duplication checks for columns that should be unique added to CI

owendelong commented 3 months ago

There are a lot of places where data appears to be duplicate in that area but actually needs to be duplicate.

For example, the VLAN list on many trunks will be identical.

There are others. Let's discuss this in more detail before too much implementation gets out of hand. ;-)