socallinuxexpo / scale-network

SCaLE's on-site expo network configurations, wifi, tooling, and scripts
https://www.socallinuxexpo.org/
BSD 3-Clause "New" or "Revised" License
40 stars 16 forks source link

Additional data consistency checks #742

Open owendelong opened 3 months ago

owendelong commented 3 months ago

Description

There are errors that can be made in switch configuration data that don't currently get caught. This will likely never be perfect, but it can definitely be improved.

Acceptance Criteria

No trunk should contain a VLAN not enumerated in the consolidated VLANs file (the result of parsing vlans + all of its includes). If a VLAN exists in the consolidated VLANs file, but doesn't appear on Uplink and Downlink ports, a warning should be generated -- ideally requiring acknowledgement and verification from a reviewer prior to merging) If a VLAN exists in the consolidated VLANs file, but is not present in all of the Uplink and Downlinks for at least one "group", an error should be generated and merging should be blocked. All of the Uplink and Downlink ports within a given group should be identical, or an error should be generated and merging should be blocked. All IPv6 addresses in configurations should be within the same /48 or an error should be generated and merging should be blocked.